Fixing compilation on Windows #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't shoot the messenger! :) |
|
FYI, you can get the patch file by adding .patch to a pull req, eg. https://github.com/bellard/quickjs/pull/51.patch |
|
Patches containing cosmetics have little chance of being accepted. Moreover, there are licensing issues with at least one file. |
TooTallNate
pushed a commit
to TooTallNate/quickjs
that referenced
this pull request
Dec 18, 2023
I believe we made enough substantial changes to have a credible claim to copyright holdership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was asked by my employer to evaluate QuickJS for usage in our Windows application. I spent a day addressing numerous issues that prevented me from compiling and linking against the library.
Thank you for your hard work and an awesome library, I hope I was able to make it a little better!